Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new reference docs #1396

Merged
merged 6 commits into from
Jul 5, 2023
Merged

Conversation

lahabana
Copy link
Contributor

Changes to leverage docs pulled directly from the repo

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@netlify
Copy link

netlify bot commented Jun 30, 2023

Deploy Preview for kuma ready!

Name Link
🔨 Latest commit 28b61c2
🔍 Latest deploy log https://app.netlify.com/sites/kuma/deploys/64a4d9ea9f043e0008f30f80
😎 Deploy Preview https://deploy-preview-1396--kuma.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana marked this pull request as ready for review June 30, 2023 15:44
@lahabana lahabana requested a review from a team as a code owner June 30, 2023 15:44
@lahabana lahabana requested review from johnharris85 and bartsmykla and removed request for a team June 30, 2023 15:44
@lahabana lahabana enabled auto-merge (squash) July 4, 2023 08:14
Signed-off-by: Charly Molter <charly.molter@konghq.com>
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I unfortunately don't have enough knowledge about ruby, so I was not able to properly review the ruby code. Except that, few nits but LGTM overall.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
app/_src/policies/meshgatewayinstance.md Outdated Show resolved Hide resolved
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla disabled auto-merge July 5, 2023 02:48
@bartsmykla bartsmykla enabled auto-merge (squash) July 5, 2023 02:48
@bartsmykla bartsmykla merged commit d81a396 into kumahq:master Jul 5, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants